From c84931dabc9cee7202e775ef01f77646458f0cfb Mon Sep 17 00:00:00 2001
From: Edwin Jakobs <edwin@rndr.studio>
Date: Mon, 20 Jan 2025 11:14:59 +0100
Subject: [PATCH] [orx-expression-evaluator] Clean-up warnings in
 MemberFunctions.kt

---
 .../kotlin/typed/MemberFunctions.kt           | 79 ++++++++++++-------
 1 file changed, 49 insertions(+), 30 deletions(-)

diff --git a/orx-expression-evaluator-typed/src/commonMain/kotlin/typed/MemberFunctions.kt b/orx-expression-evaluator-typed/src/commonMain/kotlin/typed/MemberFunctions.kt
index b102666f..54f19559 100644
--- a/orx-expression-evaluator-typed/src/commonMain/kotlin/typed/MemberFunctions.kt
+++ b/orx-expression-evaluator-typed/src/commonMain/kotlin/typed/MemberFunctions.kt
@@ -4,59 +4,78 @@ import kotlin.math.roundToInt
 
 internal fun String.memberFunctions(n: String): ((Array<Any>) -> Any)? {
     return when (n) {
-        "take" -> { n -> this.take((n[0] as Number).toInt()) }
-        "drop" -> { n -> this.drop((n[0] as Number).toInt()) }
-        "takeLast" -> { n -> this.takeLast((n[0] as Number).toInt()) }
-        "dropLast" -> { n -> this.takeLast((n[0] as Number).toInt()) }
+        "take" -> { nn -> this.take((nn[0] as Number).toInt()) }
+        "drop" -> { nn -> this.drop((nn[0] as Number).toInt()) }
+        "takeLast" -> { nn -> this.takeLast((nn[0] as Number).toInt()) }
+        "dropLast" -> { nn -> this.takeLast((nn[0] as Number).toInt()) }
         else -> null
     }
 }
 
 internal fun List<*>.memberFunctions(n: String): ((Array<Any>) -> Any)? {
     return when (n) {
-        "first" -> { n -> this.first() ?: error("empty list") }
-        "last" -> { n -> this.last() ?: error("empty list") }
-        "take" -> { n -> this.take((n[0] as Number).toInt()) }
-        "drop" -> { n -> this.drop((n[0] as Number).toInt()) }
-        "takeLast" -> { n -> this.takeLast((n[0] as Number).toInt()) }
-        "dropLast" -> { n -> this.takeLast((n[0] as Number).toInt()) }
-        "map" -> { n -> @Suppress("UNCHECKED_CAST") val lambda = (n[0] as (Any) -> Any); this.map { lambda(it!!) } }
-        "filter" -> { n ->
-            val lambda = (n[0] as (Any) -> Any); this.filter { (lambda(it!!) as Double).roundToInt() != 0 }
+        "first" -> { _ -> this.first() ?: error("empty list") }
+        "last" -> { _ -> this.last() ?: error("empty list") }
+        "take" -> { nn -> this.take((nn[0] as Number).toInt()) }
+        "drop" -> { nn -> this.drop((nn[0] as Number).toInt()) }
+        "takeLast" -> { nn -> this.takeLast((nn[0] as Number).toInt()) }
+        "dropLast" -> { nn -> this.takeLast((nn[0] as Number).toInt()) }
+        "map" -> { nn -> @Suppress("UNCHECKED_CAST") val lambda = (nn[0] as (Any) -> Any); this.map { lambda(it!!) } }
+        "filter" -> { nn ->
+            @Suppress("UNCHECKED_CAST", "UNCHECKED_CAST") val lambda =
+                (nn[0] as (Any) -> Any); this.filter { (lambda(it!!) as Double).roundToInt() != 0 }
         }
 
-        "max" -> { n ->
+        "max" -> { _ ->
             @Suppress("UNCHECKED_CAST")
             (this as List<Comparable<Any>>).max()
         }
-        "min" -> { n ->
+
+        "min" -> { _ ->
             @Suppress("UNCHECKED_CAST")
             (this as List<Comparable<Any>>).min()
         }
-        "maxBy" -> { n ->
-            @Suppress("UNCHECKED_CAST") val lambda = (n[0] as (Any) -> Any); this.maxByOrNull { lambda(it!!) as Comparable<Any> } ?: error("no max")
+
+        "maxBy" -> { nn ->
+            @Suppress("UNCHECKED_CAST") val lambda =
+                (nn[0] as (Any) -> Any); this.maxByOrNull {
+            @Suppress("UNCHECKED_CAST")
+            lambda(it!!) as Comparable<Any>
+        } ?: error("no max")
         }
 
-        "minBy" -> { n ->
-            @Suppress("UNCHECKED_CAST") val lambda = (n[0] as (Any) -> Any); this.minByOrNull { lambda(it!!) as Comparable<Any> } ?: error("no max")
+        "minBy" -> { nn ->
+            @Suppress("UNCHECKED_CAST") val lambda =
+                (nn[0] as (Any) -> Any); this.minByOrNull {
+            @Suppress("UNCHECKED_CAST")
+            lambda(it!!) as Comparable<Any>
+        } ?: error("no max")
         }
 
-        "sorted" -> { n ->
+        "sorted" -> { _ ->
             @Suppress("UNCHECKED_CAST")
             (this as List<Comparable<Any>>).sorted()
         }
-        "sortedBy" -> { n ->
-            @Suppress("UNCHECKED_CAST") val lambda = (n[0] as (Any) -> Any); this.sortedBy { lambda(it!!) as Comparable<Any> }
-        }
 
-        "sortedByDescending" -> { n ->
-            @Suppress("UNCHECKED_CAST") val lambda = (n[0] as (Any) -> Any); this.sortedByDescending { lambda(it!!) as Comparable<Any> }
-        }
-
-        "reversed" -> { n -> this.reversed() }
-        "zip" -> { n ->
+        "sortedBy" -> { nn ->
+            @Suppress("UNCHECKED_CAST") val lambda =
+                (nn[0] as (Any) -> Any); this.sortedBy {
             @Suppress("UNCHECKED_CAST")
-            this.zip(n[0] as List<Any>).map { listOf(it.first, it.second) }
+            lambda(it!!) as Comparable<Any>
+        }
+        }
+
+        "sortedByDescending" -> { nn ->
+            @Suppress("UNCHECKED_CAST") val lambda = (nn[0] as (Any) -> Any); this.sortedByDescending {
+            @Suppress("UNCHECKED_CAST")
+            lambda(it!!) as Comparable<Any>
+        }
+        }
+
+        "reversed" -> { _ -> this.reversed() }
+        "zip" -> { nn ->
+            @Suppress("UNCHECKED_CAST")
+            this.zip(nn[0] as List<Any>).map { listOf(it.first, it.second) }
         }
 
         else -> null